Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets a placeholder value for dnsServers when none is provided. #174

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

cmfcruz
Copy link
Contributor

@cmfcruz cmfcruz commented Aug 10, 2023

The image will not be configured with a custom DNS server if the variable is found to contain the placeholder value.

Change-type: patch

@cmfcruz cmfcruz changed the title Fixes the default value for dnsServers when non is provided. Fixes the default value for dnsServers when none is provided. Aug 10, 2023
@flowzone-app flowzone-app bot enabled auto-merge August 10, 2023 02:08
@cmfcruz cmfcruz force-pushed the fixup-dnsserver-default branch 3 times, most recently from ec17472 to b519f34 Compare August 11, 2023 05:26
@cmfcruz cmfcruz changed the title Fixes the default value for dnsServers when none is provided. Removes the default value for dnsServers when none is provided. Aug 11, 2023
@cmfcruz cmfcruz force-pushed the fixup-dnsserver-default branch 2 times, most recently from 432a099 to 8ecdb05 Compare August 11, 2023 06:44
@cmfcruz cmfcruz changed the title Removes the default value for dnsServers when none is provided. Sets a placeholder value for dnsServers when none is provided. Aug 11, 2023
@cmfcruz cmfcruz force-pushed the fixup-dnsserver-default branch 3 times, most recently from 4c43f4a to fe2f695 Compare August 11, 2023 10:40
@cmfcruz cmfcruz marked this pull request as draft August 13, 2023 23:51
auto-merge was automatically disabled August 13, 2023 23:51

Pull request was converted to draft

The image will not be configured with a custom DNS server
if the variable is found to contain the placeholder value.

Change-type: patch
Signed-off-by: Carlo Miguel F. Cruz <carloc@balena.io>
@cmfcruz cmfcruz marked this pull request as ready for review August 15, 2023 01:32
@flowzone-app flowzone-app bot enabled auto-merge August 15, 2023 01:33
@cmfcruz
Copy link
Contributor Author

cmfcruz commented Aug 15, 2023

lgtm

@flowzone-app flowzone-app bot merged commit b6eb608 into master Aug 15, 2023
46 checks passed
@flowzone-app flowzone-app bot deleted the fixup-dnsserver-default branch August 15, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant